Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the bootstrap modules get_state function sync #3856

Closed
Ben-PH opened this issue Apr 24, 2023 · 1 comment · Fixed by #3905
Closed

Make the bootstrap modules get_state function sync #3856

Ben-PH opened this issue Apr 24, 2023 · 1 comment · Fixed by #3905
Assignees
@Ben-PH
Labels
bootstrap Issues related to the bootstrap good first issue Good for newcomers

Comments

@Ben-PH
Copy link
Contributor

Ben-PH commented Apr 24, 2023 •
edited
Loading

The bootstrap system is entirely asynchronous but for the signature for the get_state function.

This is currently required in order to make it cancel in a tokio::select! macro inside the node. module main.rs file, with the cancellation condition being the ctrl-c interupt.

With a means to provide this cancellation without the requirement of an async context, this function can become sync.
@Ben-PH Ben-PH mentioned this issue Apr 24, 2023
Closed
25 tasks
@Ben-PH Ben-PH changed the title Make the get_state function sync Make the bootstrap modules get_state function sync Apr 24, 2023
@Ben-PH Ben-PH self-assigned this Apr 24, 2023
@Ben-PH Ben-PH added good first issue Good for newcomers bootstrap Issues related to the bootstrap client labels Apr 24, 2023
@Ben-PH Ben-PH linked a pull request May 4, 2023 that will close this issue
Syncronise get_state, and manage cancellation internally #3905
Merged
7 tasks
@Ben-PH
Copy link
Contributor Author

Ben-PH commented May 4, 2023

closed in favor of PR #3905

@Ben-PH Ben-PH closed this as completed May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ben-PH Ben-PH

Labels
bootstrap Issues related to the bootstrap good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Syncronise get_state, and manage cancellation internally massalabs/massa
1 participant
@Ben-PH