Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syncronise get_state, and manage cancellation internally #3905

Merged
merged 8 commits into from
May 17, 2023
Merged

Syncronise get_state, and manage cancellation internally #3905

merged 8 commits into from
May 17, 2023

Conversation

Ben-PH
Copy link
Contributor

@Ben-PH Ben-PH commented May 4, 2023 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Ben-PH Ben-PH marked this pull request as ready for review May 4, 2023 16:54
@Ben-PH
Copy link
Contributor Author

Ben-PH commented May 4, 2023

This might be a tough one to test properly.

@Ben-PH Ben-PH linked an issue May 4, 2023 that may be closed by this pull request
Make the bootstrap modules get_state function sync #3856
Closed
@Ben-PH Ben-PH added node bootstrap Issues related to the bootstrap labels May 4, 2023
@Ben-PH Ben-PH self-assigned this May 4, 2023
This was referenced May 4, 2023
Closed
Closed
Ben-PH
Ben-PH commented May 5, 2023
View reviewed changes
Copy link
Contributor Author

@Ben-PH Ben-PH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review

massa-bootstrap/src/client.rs Outdated Show resolved Hide resolved
massa-bootstrap/src/client.rs Outdated Show resolved Hide resolved
massa-node/src/main.rs Show resolved Hide resolved
massa-node/src/main.rs Outdated Show resolved Hide resolved
@AurelienFT
Copy link
Contributor

What's the state of this PR ?

@Ben-PH
Copy link
Contributor Author

Ben-PH commented May 10, 2023

Ready for review. I've had it up in core-review. I'll request your review now.

@Ben-PH Ben-PH requested a review from AurelienFT May 10, 2023 15:55
Ben-PH added a commit that referenced this pull request May 10, 2023
@Ben-PH
Manually bring in core elements of PR #3905
fc04735
@Ben-PH
Copy link
Contributor Author

Ben-PH commented May 17, 2023

most of the changes were upstreamed into main, so what remains is really just formatting/typos now.

@Ben-PH Ben-PH requested a review from modship May 17, 2023 08:35
@Ben-PH Ben-PH merged commit 2be7e96 into testnet_23 May 17, 2023
@Ben-PH Ben-PH mentioned this pull request May 22, 2023
Closed
15 tasks
@AurelienFT AurelienFT deleted the bootstrap/sync-get_state branch May 29, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modship modship modship approved these changes

@AurelienFT AurelienFT Awaiting requested review from AurelienFT

Assignees

@Ben-PH Ben-PH

Labels
bootstrap Issues related to the bootstrap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the bootstrap modules get_state function sync
3 participants
@Ben-PH @AurelienFT @modship