Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the id of messages in protocol #3961

Closed
AurelienFT opened this issue May 17, 2023 · 1 comment
Closed

Change the id of messages in protocol #3961

AurelienFT opened this issue May 17, 2023 · 1 comment

Comments

@AurelienFT
Copy link
Contributor

Context

Currently, in the network we are using a single ID for each message but this ID has two roles: to determine which handler should manage this and what is the message type within this handler.

Problem

Adding a new message in an handler at the middle of the others will change the id of the messages of the others handlers also.

Solution

Use two varint u64 as version one for handler, the other for the inner type.

@AurelienFT
Copy link
Contributor Author

Fix in #3979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant