Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new config from peernet. #3979

Merged
merged 2 commits into from
May 25, 2023
Merged

Fix new config from peernet. #3979

merged 2 commits into from
May 25, 2023

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented May 24, 2023 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Update Peernet and fix #3961

@AurelienFT AurelienFT requested a review from modship May 24, 2023 16:45
@AurelienFT AurelienFT merged commit 765fe8b into testnet_23 May 25, 2023
@AurelienFT AurelienFT mentioned this pull request May 25, 2023
Closed
@AurelienFT AurelienFT deleted the remove_old_method branch May 29, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modship modship modship approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AurelienFT @modship