Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a adress in SC use the wrong strategy #4022

Closed
4 tasks done
sydhds opened this issue Jun 2, 2023 · 0 comments
Closed
4 tasks done

Creating a adress in SC use the wrong strategy #4022

sydhds opened this issue Jun 2, 2023 · 0 comments
Assignees
Labels
bug Something isn't working p1

Comments

@sydhds
Copy link
Contributor

sydhds commented Jun 2, 2023

  • generating an SC address in create_new_sc_address should be deterministic - so we must use the current context slot of the SC for the address factory strategy
  • the factory strategy should not be an option, but an explicit requirement (not only for addresses but also for all the other factories)
  • FactoryStrategy::Latest shouldn't be used anywhere in the node except when generating a new local node ID. So maybe it is worth removing it and letting the user use At(now()) when needed. Also make sure that At(t) when t is lower that the first mip start date gives the first mip version
  • Check that an Address derived from Keypair matches the version of the keypair (as an example: check that for a Keypair v1 we derive an Address v1)
@sydhds sydhds self-assigned this Jun 2, 2023
@damip damip added bug Something isn't working p1 critical labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1
Projects
None yet
Development

No branches or pull requests

3 participants