Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent coin transfer to SC addresses #4027

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Prevent coin transfer to SC addresses #4027

merged 2 commits into from
Jun 12, 2023

Conversation

damip
Copy link
Member

@damip damip commented Jun 2, 2023 •
edited
Loading

Solves #3247

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds mentioned this pull request Jun 2, 2023
Closed
4 tasks
sydhds added a commit that referenced this pull request Jun 2, 2023
@sydhds
Fix address creation in SC (cherry pick from PR #4027 by damip)
270265f
sydhds added a commit that referenced this pull request Jun 2, 2023
@sydhds
Remove FactoryStrategy::Latest variant (#4028)
fbd1950 
* Remove FactoryStrategy::Latest variant

* Fix address creation in SC (cherry pick from PR #4027 by damip)

---------

Co-authored-by: sydhds <sydhds@gmail.com>
@sydhds sydhds force-pushed the prevent_sc_coin_transfer branch from 68db6bd to fa535ac Compare June 6, 2023 13:08
AurelienFT
AurelienFT reviewed Jun 12, 2023
View reviewed changes
massa-execution-worker/src/context.rs Outdated Show resolved Hide resolved
massa-execution-worker/src/execution.rs Outdated Show resolved Hide resolved
AurelienFT
AurelienFT approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me. I think you can merge it.

@damip damip merged commit 9f3a59d into testnet_24 Jun 12, 2023
@sydhds sydhds deleted the prevent_sc_coin_transfer branch June 14, 2023 07:25
@AurelienFT AurelienFT mentioned this pull request Jun 19, 2023
Closed
@Leo-Besancon Leo-Besancon mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damip @AurelienFT