Add start node command to client #1728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yvan-sraka this issue with the config files wasn't solved ? |
yvan-sraka
changed the title
|
Not yet :/ |
|
@yvan-sraka so this issue is blocked until the config related ones aren't solved ? |
|
Yes! Blocked by #1277 |
|
This is actually hard to make in a clean and portable way... maybe let's close it for now |
|
It's easy to do it in a clean and portable way! I will come with a solution this week :) |
|
@yvan-sraka is there a bot that is able to ping us in a week ? |
|
Just need #1848 to be merged and we're good :) |
|
This issue is still blocked right ? |
Not anymore! Since #1848 have been merged :) |
AureliaDolo
reviewed
Dec 14, 2021
yvan-sraka
force-pushed
the
159-add-start-node-command-to-client
branch
from
7728752 to
9647b7c
Compare
yvan-sraka
force-pushed
the
159-add-start-node-command-to-client
branch
from
9647b7c to
6193598
Compare
yvan-sraka
force-pushed
the
159-add-start-node-command-to-client
branch
from
6193598 to
25bdaaa
Compare
|
Can you fix the CI before review process please ? @yvan-sraka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GitLab by @yvan-sraka
Closes #159