Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test transition crate #3442

Closed
wants to merge 6 commits into from
Closed

Test transition crate #3442

wants to merge 6 commits into from

Conversation

AurelienFT
Copy link
Contributor

No description provided.

@AurelienFT AurelienFT marked this pull request as draft January 19, 2023 15:06
Comment on lines 143 to 144
<Address!["1"]>::VERSION => Ok(AddressVariant!["2"](<Address!["2"]>::from_bytes(
rest.try_into()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Address!["1"]>::VERSION => Ok(AddressVariant!["2"](<Address!["2"]>::from_bytes(
rest.try_into()
<Address!["2"]>::VERSION => Ok(AddressVariant!["2"](<Address!["2"]>::from_bytes(
rest.try_into()

Typo?

@AurelienFT AurelienFT mentioned this pull request Feb 1, 2023
7 tasks
@AurelienFT AurelienFT changed the base branch from testnet_19 to testnet_20 February 1, 2023 15:04
@Leo-Besancon
Copy link
Collaborator

I merged some of the commits in this PR in #3471.
Closing as a result.

@Leo-Besancon Leo-Besancon deleted the test_transition_crate branch February 2, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants