Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mid term double stake protection #3646

Merged
merged 8 commits into from
Mar 6, 2023
Merged

Mid term double stake protection #3646

merged 8 commits into from
Mar 6, 2023

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Mar 6, 2023 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Didn't tested it yet. We don't have unit tests for consensus. I will test in labnet if solution is validated.

@AurelienFT AurelienFT requested a review from damip March 6, 2023 10:57
@AurelienFT AurelienFT changed the title Mid term double stake Mid term double stake protection Mar 6, 2023
@AurelienFT AurelienFT requested a review from damip March 6, 2023 13:33
@AurelienFT AurelienFT requested a review from damip March 6, 2023 14:26
damip
damip approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@damip damip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) gg

@AurelienFT AurelienFT merged commit 51e1943 into consensus_documentation Mar 6, 2023
@AurelienFT AurelienFT mentioned this pull request Apr 3, 2023
Closed
@AurelienFT AurelienFT deleted the mid_term_double_stake branch May 29, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damip damip damip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AurelienFT @damip