Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bind ipv4 only network #3653

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Fix bind ipv4 only network #3653

merged 4 commits into from
Mar 7, 2023

Conversation

Leo-Besancon
Copy link
Collaborator

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Leo-Besancon
Copy link
Collaborator Author

Context: issue #3650
The fix for ipv4 network on windows previously made here (#3590) was working on windows, but not on ubuntu with IPv6 disabled at a system level.
Here, someone with IPv6 disabled (and not "just" no IPv6 interface exposed) can bind to 0.0.0.0 for the network and bootstrap controllers.

Should I add some more comments on the config.toml bind settings?

@Leo-Besancon Leo-Besancon linked an issue Mar 6, 2023 that may be closed by this pull request
Massa node crash if IPV6 is disabled on server. #3650
Closed
aoudiamoncef
aoudiamoncef approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@aoudiamoncef aoudiamoncef left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good for me. Just add a small comment to explain the context.

If you have a specific behaviour linked to a specific OS in the future, take a look at https://doc.rust-lang.org/reference/conditional-compilation.html#target_os, It may help.

@Leo-Besancon
Copy link
Collaborator Author

It seems good for me. Just add a small comment to explain the context.

If you have a specific behaviour linked to a specific OS in the future, take a look at https://doc.rust-lang.org/reference/conditional-compilation.html#target_os, It may help.

Great, will do, thanks for the link!

@Leo-Besancon Leo-Besancon merged commit 2c36ea7 into testnet_21 Mar 7, 2023
@Leo-Besancon Leo-Besancon deleted the fix_bind_ipv4_only_network branch March 7, 2023 07:25
Leo-Besancon added a commit that referenced this pull request Mar 8, 2023
@Leo-Besancon
Fix bind ipv4 only network (#3653)
668834c 
* initial fix

* Do not set ipv6 flag if ipv4 only

* fmt

* Added documentation and comments
bors bot added a commit that referenced this pull request Mar 8, 2023
@bors @Leo-Besancon
Merge #3657
bd76ce8 
3657: Fix bind ipv4 only network (#3653) r=AurelienFT a=Leo-Besancon

* initial fix

* Do not set ipv6 flag if ipv4 only

* fmt

* Added documentation and comments

* [ ] document all added functions
* [ ] try in sandbox /simulation/labnet
* [ ] unit tests on the added/changed features
  * [ ] make tests compile
  * [ ] make tests pass 
* [ ] add logs allowing easy debugging in case the changes caused problems
* [ ] if the API has changed, update the API specification

Co-authored-by: Leo-Besancon <lb@massa.net>
Ben-PH added a commit that referenced this pull request Mar 10, 2023
@Ben-PH
Integrate PR #3653 fixes into the get_listener
a8b8587 
Co-authored-by: Léo Besançon lb@massa.net
Ben-PH added a commit that referenced this pull request Mar 10, 2023
@Ben-PH
Integrate PR #3653 fixes into the get_listener
472c1b0 
Co-authored-by: Léo Besançon lb@massa.net
Ben-PH added a commit that referenced this pull request Mar 13, 2023
@Ben-PH
Integrate PR #3653 fixes into the get_listener
8c8a6a0 
Co-authored-by: Léo Besançon lb@massa.net
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoudiamoncef aoudiamoncef aoudiamoncef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Massa node crash if IPV6 is disabled on server.
2 participants
@Leo-Besancon @aoudiamoncef