Fix vesting file (old timestamp) #3654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurelienFT
reviewed
Mar 7, 2023
|
|
||
| Ok(prev) | ||
| }) | ||
| // we don't need range with StartSlot(0,0) && EndSlot(0,0) |
There was a problem hiding this comment.
We need the range with the start timestamp at genesis otherwise from genesis to X there is no vesting.
There was a problem hiding this comment.
yes we have it, my filter is && not ||.
Here we don't want vesting range with start_slot(0,0) and end_slot(0,0).
This happens when the timestamp in vesting_file is passed for the first launch of BC. There is no block at the timestamp.
So the next range (and the first in the map) has start_slot(0,0) and end_slot(Slot valide timestamp).
Sorry if i don't explain well
modship
pushed a commit
that referenced
this pull request
Mar 8, 2023
bors bot
added a commit
that referenced
this pull request
Mar 8, 2023
3659: fix vesting file (#3654) r=AurelienFT a=modship * [X] document all added functions * [X] try in sandbox /simulation/labnet * [X] unit tests on the added/changed features * [X] make tests compile * [X] make tests pass * [X] add logs allowing easy debugging in case the changes caused problems * [X] if the API has changed, update the API specification Co-authored-by: modship <lu@massa.net>
modship
added a commit
that referenced
this pull request
Mar 20, 2023
* fix(vesting) : fix init slot with passed timestamp #3654
modship
added a commit
that referenced
this pull request
Mar 20, 2023
* fix(vesting) : fix init slot with passed timestamp #3654
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3651