Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colors to the CLI #3661

Merged
merged 20 commits into from
Mar 22, 2023
Merged

Add colors to the CLI #3661

merged 20 commits into from
Mar 22, 2023

Conversation

litchipi
Copy link
Contributor

@litchipi litchipi commented Mar 8, 2023

Implements #3294

Adds generic styling implementation

Also serves as a tracking PR for:

Signed-off-by: Litchi Pi <litchi.pi@proton.me>
litchipi added 7 commits March 8, 2023 14:52
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
litchipi added 6 commits March 8, 2023 18:43
Add colors on the get_operations command
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
@litchipi
Copy link
Contributor Author

litchipi commented Mar 9, 2023

Colors in screenshots may have changed since they were created, please try it on your own machine

@litchipi litchipi marked this pull request as ready for review March 13, 2023 08:30
@litchipi
Copy link
Contributor Author

Please tell me if you want to see more commands implementing colors output

Signed-off-by: Litchi Pi <litchi.pi@proton.me>
Signed-off-by: Litchi Pi <litchi.pi@proton.me>
@litchipi
Copy link
Contributor Author

litchipi commented Mar 22, 2023

@modship Ready for review & merge as it's been a while it is open
It'll be possible to edit some of the changes (colors, add more commands, etc ...) later based on what is being discussed, but I think it's good to have the base merged for now

@modship
Copy link
Member

modship commented Mar 22, 2023

@modship Ready for review & merge as it's been a while it is open It'll be possible to edit some of the changes (colors, add more commands, etc ...) later based on what is being discussed, but I think it's good to have the base merged for now

i can review your code but don't know for color. Maybe someone else has better opinion than mine ^^

@litchipi litchipi merged commit 7a4a31e into testnet_21 Mar 22, 2023
@AurelienFT AurelienFT deleted the client_cli_colors branch May 29, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants