Feature/denunciation reloaded

[sydhds]

• document all added functions
• try in sandbox /simulation/labnet
• unit tests on the added/changed features
  • make tests compile
  • make tests pass
• add logs allowing easy debugging in case the changes caused problems
• if the API has changed, update the API specification

[damip]

I find it a bit weird to use a Serializer for DenunciationData because:

• it doesn't really serialize (for example the variant number of the enum is not encoded)
• it can return an Error which complicates everything upstream, but compute_hash does not need to return a Result

This can be simplified by having two strucutres (we don't need an enum there, does not serve any genericity purpose anyway):

• EndorsementDenunciationData with public fields and a to_bytes() method
• BlockHeaderDenunciationData with public fields and a to_bytes() method

I would also define the EndorsementDenunciationData within the endorsement.rs file to avoid circular dependencies between denunciation.rs and endorsement.rs. Would do the same for the block header.

What do you think ?

[sydhds]

I find it a bit weird to use a Serializer for DenunciationData because:

• it doesn't really serialize (for example the variant number of the enum is not encoded)
• it can return an Error which complicates everything upstream, but compute_hash does not need to return a Result

This can be simplified by having two strucutres (we don't need an enum there, does not serve any genericity purpose anyway):

• EndorsementDenunciationData with public fields and a to_bytes() method
• BlockHeaderDenunciationData with public fields and a to_bytes() method

I would also define the EndorsementDenunciationData within the endorsement.rs file to avoid circular dependencies between denunciation.rs and endorsement.rs. Would do the same for the block header.

What do you think ?

Done