Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vesting test #3676

Merged
merged 5 commits into from
Mar 13, 2023
Merged

Fix vesting test #3676

merged 5 commits into from
Mar 13, 2023

Conversation

modship
Copy link
Member

@modship modship commented Mar 10, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@modship modship requested a review from Ben-PH March 10, 2023 17:22
Ben-PH
Ben-PH reviewed Mar 10, 2023
View reviewed changes
Copy link
Contributor

@Ben-PH Ben-PH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

I put together PR #3678 apply a couple of change-requests as well as a couple of minor review comments.

massa-execution-worker/src/tests/mock.rs Outdated Show resolved Hide resolved
massa-execution-worker/src/tests/mock.rs Outdated Show resolved Hide resolved
@Ben-PH Ben-PH mentioned this pull request Mar 10, 2023
Merged
8 tasks
Ben-PH and others added 2 commits March 10, 2023 20:10
@Ben-PH
Fix/vesting test review requests (#3678)
3777957 
* Fix clippy lint: unused result

* include test helpers when testing without "testing" feature
refactor(test) : add const for timestamp
ed1c622
@Ben-PH Ben-PH mentioned this pull request Mar 13, 2023
Merged
7 tasks
@modship modship merged commit 0537065 into testnet_21 Mar 13, 2023
modship pushed a commit that referenced this pull request Mar 20, 2023
@Ben-PH
Fix test (#3676)
c196d81 
* fix(vesting) : check if amount != 0 before checking vesting

* test(vesting) : update mocked data

* Fix/vesting test review requests (#3678)

* Fix clippy lint: unused result

* include test helpers when testing without "testing" feature

* refactor(test) : add const for timestamp

---------

Co-authored-by: Ben <benphawke@gmail.com>
modship pushed a commit that referenced this pull request Mar 20, 2023
@Ben-PH
Fix test (#3676)
96fb90e 
* fix(vesting) : check if amount != 0 before checking vesting

* test(vesting) : update mocked data

* Fix/vesting test review requests (#3678)

* Fix clippy lint: unused result

* include test helpers when testing without "testing" feature

* refactor(test) : add const for timestamp

---------

Co-authored-by: Ben <benphawke@gmail.com>
@AurelienFT AurelienFT deleted the fix/vesting_test branch May 29, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ben-PH Ben-PH Ben-PH left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@modship @Ben-PH