New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benph/unwrap to expect #3693

Merged

Ben-PH merged 2 commits into testnet_21 from benph/unwrap-to-expect

Mar 30, 2023

Contributor

Ben-PH commented Mar 20, 2023

document all added functions
try in sandbox /simulation/labnet
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification

Ben-PH added 2 commits

March 20, 2023 12:42


          unwrap -> expect


          Remove redundant comments

832bb2e

Ben-PH mentioned this pull request

Testnet 20 #3489

Merged

Leo-Besancon approved these changes

View reviewed changes

Collaborator

Leo-Besancon left a comment

Nice cleanup

Ben-PH merged commit c2b77ad into testnet_21

AurelienFT deleted the benph/unwrap-to-expect branch

May 29, 2023 09:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet