Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle an empty array when parsing to a bool #3696

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Handle an empty array when parsing to a bool #3696

merged 1 commit into from
Mar 21, 2023

Conversation

Ben-PH
Copy link
Contributor

@Ben-PH Ben-PH commented Mar 20, 2023 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Ben-PH Ben-PH mentioned this pull request Mar 20, 2023
Merged
Leo-Besancon
Leo-Besancon approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Note: we will need to backport it to testnet 20 ;)

@Ben-PH Ben-PH changed the base branch from testnet_21 to testnet_20_2 March 21, 2023 17:23
@Ben-PH Ben-PH force-pushed the fix/bool-parse-empty-array branch from 591cd72 to f6fa269 Compare March 21, 2023 17:29
@Ben-PH Ben-PH requested a review from Leo-Besancon March 21, 2023 17:37
@Ben-PH Ben-PH marked this pull request as ready for review March 21, 2023 17:37
@damip damip merged commit ef5c0b9 into testnet_20_2 Mar 21, 2023
@AurelienFT AurelienFT deleted the fix/bool-parse-empty-array branch May 29, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

@damip damip damip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ben-PH @damip @Leo-Besancon