New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix to optim denunciation creation from 2 SecuredHeader #3718

Merged

sydhds merged 1 commit into testnet_21 from feature/denunciation_reloaded_followup_1

Mar 22, 2023

Contributor

sydhds commented Mar 22, 2023

document all added functions
try in sandbox /simulation/labnet
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification


          Minor fix to optim denunciation creation from 2 SecuredHeader

926e1ae

sydhds requested a review from bilboquet

March 22, 2023 16:30

bilboquet approved these changes

View reviewed changes

Contributor

bilboquet left a comment

ok for me.

sydhds merged commit 9eef56f into testnet_21

sydhds deleted the feature/denunciation_reloaded_followup_1 branch

March 22, 2023 17:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet