Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial code for DenunciationFactory & DenunciationPool #3734

Merged
merged 13 commits into from
Apr 3, 2023
Merged

Initial code for DenunciationFactory & DenunciationPool #3734

merged 13 commits into from
Apr 3, 2023

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Mar 28, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds requested review from damip and bilboquet March 29, 2023 17:25
@sydhds sydhds marked this pull request as ready for review March 29, 2023 17:26
@sydhds sydhds force-pushed the feature/denunciation_factory_1 branch from 57817e5 to ac0f1c6 Compare March 30, 2023 07:01
modship
modship reviewed Mar 30, 2023
View reviewed changes
massa-consensus-exports/src/channels.rs Outdated Show resolved Hide resolved
massa-factory-worker/src/denunciation_factory.rs Outdated Show resolved Hide resolved
massa-factory-worker/src/denunciation_factory.rs Outdated Show resolved Hide resolved
massa-factory-worker/src/denunciation_factory.rs Outdated Show resolved Hide resolved
massa-factory-worker/src/denunciation_factory.rs Outdated Show resolved Hide resolved
massa-models/src/denunciation.rs Outdated Show resolved Hide resolved
massa-models/src/denunciation.rs Outdated Show resolved Hide resolved
massa-node/src/main.rs Show resolved Hide resolved
massa-pool-worker/src/denunciation_pool.rs Outdated Show resolved Hide resolved
massa-pool-worker/src/denunciation_pool.rs Outdated Show resolved Hide resolved
damip
damip reviewed Mar 30, 2023
View reviewed changes
massa-storage/src/lib.rs Outdated Show resolved Hide resolved
@sydhds sydhds requested a review from damip April 3, 2023 08:02
@damip damip mentioned this pull request Apr 3, 2023
Closed
@sydhds sydhds merged commit 8512742 into testnet_21 Apr 3, 2023
@sydhds sydhds deleted the feature/denunciation_factory_1 branch April 3, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modship modship modship left review comments

@bilboquet bilboquet bilboquet left review comments

@damip damip damip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sydhds @bilboquet @modship @damip