Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mip store bootstrap #3765

Merged
merged 4 commits into from
Apr 5, 2023
Merged

Add mip store bootstrap #3765

merged 4 commits into from
Apr 5, 2023

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Apr 4, 2023

No description provided.

@sydhds sydhds force-pushed the feature/versioning_bootstrap branch from 281b649 to a845dc1 Compare April 4, 2023 14:38
@sydhds sydhds marked this pull request as ready for review April 4, 2023 15:06
@sydhds sydhds requested a review from Leo-Besancon April 4, 2023 15:06
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems clean to me👍. I think it would be worth it to have a second opinion (maybe @Ben-PH?) on the bootstrap module additions, in case I missed something there!

massa-proto/build.rs Outdated Show resolved Hide resolved
massa-node/src/main.rs Show resolved Hide resolved
@sydhds sydhds requested review from Ben-PH and Leo-Besancon April 5, 2023 07:19
Copy link
Contributor

@Ben-PH Ben-PH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't cause any issues with the bootstrap system from what I can tell.

Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think Versioning is coming together nicely!

@sydhds sydhds force-pushed the feature/versioning_bootstrap branch from 41f038e to 5a726ad Compare April 5, 2023 12:39
@sydhds sydhds merged commit ef79242 into testnet_21 Apr 5, 2023
@sydhds sydhds deleted the feature/versioning_bootstrap branch April 5, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants