Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panics if we are before genesis timestamp #3768

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Panics if we are before genesis timestamp #3768

merged 2 commits into from
Apr 5, 2023

Conversation

Leo-Besancon
Copy link
Collaborator

Used to prevent nodes to desync in case we keep a different ledger than they have.

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Leo-Besancon
Panics if we are before genesis timestamp
27242f8 
Used to prevent nodes to desync in case we keep a different ledger than they have.
@Leo-Besancon
Deactivate the check if we are in sandbox
8649621
@Leo-Besancon Leo-Besancon requested a review from AurelienFT April 5, 2023 09:30
@Leo-Besancon Leo-Besancon merged commit 3357a6b into testnet_21 Apr 5, 2023
@Leo-Besancon Leo-Besancon deleted the prevent_launch_before_genesis branch April 6, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leo-Besancon @AurelienFT