Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fix net restart #3777

Merged
merged 9 commits into from
Apr 6, 2023
Merged

Test fix net restart #3777

merged 9 commits into from
Apr 6, 2023

Conversation

Leo-Besancon
Copy link
Collaborator

@Leo-Besancon Leo-Besancon commented Apr 6, 2023 •
edited by damip
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Leo-Besancon Leo-Besancon mentioned this pull request Apr 6, 2023
Closed
7 tasks
@Leo-Besancon Leo-Besancon marked this pull request as ready for review April 6, 2023 06:31
@Leo-Besancon Leo-Besancon requested a review from AurelienFT April 6, 2023 06:31
@Leo-Besancon
Update downtime timestamps
1a7c800 
10AM > 11AM on 6th of april
AurelienFT
AurelienFT approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve let's wait the labnet test before merge

@Leo-Besancon Leo-Besancon merged commit 87ede00 into testnet_21 Apr 6, 2023
@Leo-Besancon Leo-Besancon deleted the test_fix_net_restart branch April 6, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leo-Besancon @AurelienFT