Feature/denunciation factory more feed #3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sydhds
commented
Apr 12, 2023
sydhds
commented
- document all added functions
- try in sandbox /simulation/labnet
- unit tests on the added/changed features
- make tests compile
- make tests pass
- add logs allowing easy debugging in case the changes caused problems
- if the API has changed, update the API specification
sydhds
force-pushed
the
feature/denunciation_factory_more_feed
branch
from
8888e99 to
46bd267
Compare
This reverts commit 4d4447f.
damip
reviewed
Apr 12, 2023
massa-models/src/block_header.rs
Outdated
| @@ -70,12 +73,17 @@ impl BlockHeader { | |||
| let mut set = HashSet::new(); | |||
| for endo in self.endorsements.iter() { | |||
| // ...and check signatures + invariants while at it | |||
| endo.check_invariants()?; | |||
| // endo.check_invariants()?; | |||
There was a problem hiding this comment.
Was for debugging a test and forgot to re enable. Fixed.
Ben-PH
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Initial code to add denunciations in block header * Early removal use of DenunciationPool in DenunciationFactory * Revert "Early removal use of DenunciationPool in DenunciationFactory" This reverts commit 4d4447f. * Restore assert_invariants * Restore assert_invariants (round 2) --------- Co-authored-by: sydhds <sydhds@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.