Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial code in order to process denunciation #3829

Merged
merged 7 commits into from
Apr 19, 2023
Merged

Add initial code in order to process denunciation #3829

merged 7 commits into from
Apr 19, 2023

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Apr 14, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds force-pushed the feature/denunciation_process_1 branch from fcde98f to 5ff2214 Compare April 14, 2023 15:28
@sydhds sydhds marked this pull request as ready for review April 18, 2023 09:35
@sydhds sydhds requested review from damip and bilboquet April 18, 2023 09:36
damip
damip reviewed Apr 18, 2023
View reviewed changes
Copy link
Member

@damip damip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good ! A couple details (see comments) + missing documentation

@sydhds sydhds requested a review from damip April 19, 2023 08:30
@sydhds sydhds force-pushed the feature/denunciation_process_1 branch from b47ce32 to ad42daa Compare April 19, 2023 08:57
@bilboquet
Copy link
Contributor

Everything I could have think of has already been caught :)
looks good to me

damip
damip approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@damip damip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good !

@sydhds sydhds merged commit b1ee23e into testnet_22 Apr 19, 2023
@sydhds sydhds deleted the feature/denunciation_process_1 branch April 19, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damip damip damip approved these changes

@bilboquet bilboquet Awaiting requested review from bilboquet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sydhds @bilboquet @damip