Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize time with lock. #3830

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Optimize time with lock. #3830

merged 1 commit into from
Apr 17, 2023

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Apr 17, 2023 •
edited by ghost
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Fix #3705

🤖 Generated by Copilot at e711cce

Summary

🔀🚀🔓

Improved performance of the execution worker by minimizing read lock duration in controller.rs.

read lock released
performance improved by swap
winter of waiting

Walkthrough

  • Swap the order of statements to release the read lock earlier and improve performance (link)

@AurelienFT AurelienFT requested a review from aoudiamoncef April 17, 2023 09:28
aoudiamoncef
aoudiamoncef approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@aoudiamoncef aoudiamoncef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍🏻

@AurelienFT AurelienFT merged commit 604077e into testnet_22 Apr 17, 2023
Ben-PH pushed a commit that referenced this pull request Apr 17, 2023
@AurelienFT @Ben-PH
Optimize time with lock. (#3830)
6cc2844
@AurelienFT AurelienFT deleted the optimize_lock branch May 29, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoudiamoncef aoudiamoncef aoudiamoncef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AurelienFT @aoudiamoncef