Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for already processed denunciations in execution worker #3853

Merged
merged 7 commits into from
Apr 24, 2023
Merged

Check for already processed denunciations in execution worker #3853

merged 7 commits into from
Apr 24, 2023

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Apr 24, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds requested review from bilboquet and damip April 24, 2023 10:07
@sydhds sydhds requested a review from damip April 24, 2023 13:14
@sydhds sydhds merged commit 2273979 into testnet_22 Apr 24, 2023
@sydhds sydhds deleted the processed_de_1 branch April 24, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damip damip damip left review comments

@bilboquet bilboquet Awaiting requested review from bilboquet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydhds @damip