Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use blocking_send instead of the async send #3855

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Use blocking_send instead of the async send #3855

merged 2 commits into from
Apr 24, 2023

Conversation

Ben-PH
Copy link
Contributor

@Ben-PH Ben-PH commented Apr 24, 2023 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Ben-PH Ben-PH added the bootstrap Issues related to the bootstrap label Apr 24, 2023
@Ben-PH Ben-PH self-assigned this Apr 24, 2023
@Ben-PH Ben-PH mentioned this pull request Apr 24, 2023
Closed
7 tasks
@Ben-PH Ben-PH requested a review from modship April 24, 2023 12:49
@Ben-PH Ben-PH merged commit c51fac5 into testnet_22 Apr 24, 2023
@AurelienFT AurelienFT deleted the bootstrap/exorcise_async branch May 29, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modship modship modship approved these changes

Assignees

@Ben-PH Ben-PH

Labels
bootstrap Issues related to the bootstrap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ben-PH @modship