Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two extra saved cycles to PoS for denunciations checks #3871

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

Eitu33
Copy link
Contributor

@Eitu33 Eitu33 commented Apr 26, 2023

No further changes need to be done than saving 2 extra cycles because:

  1. We feed every cycle we get after bootstrapping in compute_initial_draws
  2. Fed cycles are computed in the same order they are fed and the selector thread checks sequentiality
  3. We wait for every cycle to be drawn up to C+2 (C being the latest cycle received from bootstrap) here, and we now receive 6 cycles after this change, giving us the draws for C-2, C-1, C, C+1, C+2

image

@damip damip mentioned this pull request Apr 26, 2023
9 tasks
@Eitu33 Eitu33 requested a review from damip April 26, 2023 13:25
@Eitu33 Eitu33 changed the title Add one saved cycle to PoS for denunciations checks Add two extra saved cycle to PoS for denunciations checks Apr 26, 2023
@Eitu33 Eitu33 changed the title Add two extra saved cycle to PoS for denunciations checks Add two extra saved cycles to PoS for denunciations checks Apr 26, 2023
Copy link
Member

@damip damip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eitu33 Eitu33 merged commit a1e9b5e into testnet_22 Apr 26, 2023
@AurelienFT AurelienFT deleted the add-one-saved-cycle branch May 29, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants