Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add denunciations documentation #3877

Merged
merged 10 commits into from
Apr 27, 2023
Merged

Add denunciations documentation #3877

merged 10 commits into from
Apr 27, 2023

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Apr 27, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds mentioned this pull request Apr 27, 2023
Closed
9 tasks
damip
damip reviewed Apr 27, 2023
View reviewed changes
massa-models/src/denunciation.rs Outdated Show resolved Hide resolved
massa-models/src/denunciation.rs Outdated Show resolved Hide resolved
sydhds and others added 8 commits April 27, 2023 15:48
@sydhds @damip
Update massa-models/src/denunciation.rs
0453d92 
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
@sydhds @damip
Update massa-models/src/denunciation.rs
c62cbe2 
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
@sydhds @damip
Update massa-models/src/denunciation.rs
95c4415 
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
@sydhds @damip
Update massa-models/src/denunciation.rs
08b91c3 
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
@sydhds @damip
Update massa-models/src/denunciation.rs
4165b66 
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
@sydhds @damip
Update massa-models/src/denunciation.rs
4382a66 
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
@sydhds @damip
Update massa-models/src/denunciation.rs
f09dfcf 
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
@sydhds @damip
Update massa-models/src/denunciation.rs
981bda9 
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
@sydhds sydhds merged commit b65b175 into testnet_22 Apr 27, 2023
@sydhds sydhds deleted the feature/denunc_doc_and_cleanup branch April 27, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damip damip damip left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydhds @damip