Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix network #3900

Merged
merged 1 commit into from
May 3, 2023
Merged

fix network #3900

merged 1 commit into from
May 3, 2023

Conversation

modship
Copy link
Member

@modship modship commented May 3, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@modship
Copy link
Member Author

modship commented May 3, 2023

last problem, is global dosn"t work for ipv6 -> IPv4-mapped addresses : https://doc.rust-lang.org/std/net/struct.Ipv6Addr.html#method.is_global

so tester dosn't work

@AurelienFT AurelienFT merged commit a9aab0e into testnet_22 May 3, 2023
@modship modship deleted the testnet_22_fix_network branch May 11, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants