-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove assumptions about knowing a peer in protocol and fix memory leak #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damip
reviewed
May 4, 2023
AurelienFT
changed the title
Remove assumptions about knowing a peer in protocol
Remove assumptions about knowing a peer in protocol and fix memory leak
May 4, 2023
damip
approved these changes
May 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at c7138c1
Summary
🐛🚀🎨
This pull request improves the code quality, performance, and reliability of the massa-protocol-worker and massa-async-pool crates, and updates the peernet dependency in several other crates. It also fixes some minor code style issues and documentation comments. The main changes include using the
tracing
crate for logging, simplifying the data structures and algorithms for indexing and retrieving blocks and operations, and increasing the timeout durations for peer connections.Walkthrough
massa-async-pool/src/changes.rs
and remove the redundant one (link, link)peernet
crate in threeCargo.toml
files to use a newer revision (link, link, link)info
macro and replace aprintln!
call with aninfo!
call inmassa-protocol-worker/src/connectivity.rs
to use the proper logging mechanism (link, link)massa-pool-worker/src/denunciation_pool.rs
andmassa-protocol-worker/src/handlers/block_handler/retrieval.rs
for code style consistency (link, link, link, link, link, link)cache_write
lock acquisition inside the loop over theblock_wishlist
inmassa-protocol-worker/src/handlers/block_handler/retrieval.rs
to avoid blocking other threads (link)iter
andbreak
pattern with theretain
method on thestored_operations
BTreeMap inmassa-protocol-worker/src/handlers/operation_handler/retrieval.rs
to simplify the code (link)index_by_newest
field in thePeerDB
struct from a BTreeMap to a BTreeSet, and update the corresponding methods and calls inmassa-protocol-worker/src/handlers/peer_handler/mod.rs
,massa-protocol-worker/src/handlers/peer_handler/models.rs
, andmassa-protocol-worker/src/handlers/peer_handler/tester.rs
to use the set operations (link, link, link, link, link, link)test_peer
function and thetry_connect
calls inmassa-protocol-worker/src/handlers/peer_handler/mod.rs
andmassa-protocol-worker/src/handlers/peer_handler/tester.rs
to give more time for the peer to respond (link, link, link)