Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix final slot exec broadcast #3928

Merged
merged 1 commit into from
May 11, 2023
Merged

Fix final slot exec broadcast #3928

merged 1 commit into from
May 11, 2023

Conversation

aoudiamoncef
Copy link
Contributor

@aoudiamoncef aoudiamoncef commented May 10, 2023 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

🤖 Generated by Copilot at d8c2e41

Summary

📢🗂️🐑

Add feature to broadcast final slot execution output to subscribers in execution.rs. Clone exec_out to avoid ownership issues.

exec_out cloned
Broadcast to subscribers
Cache holds the answer

Walkthrough

  • Add a feature to broadcast the final slot execution output to active channel subscribers (link)

modship
modship previously approved these changes May 10, 2023
View reviewed changes
@aoudiamoncef aoudiamoncef force-pushed the hotfix/final-slot-exec branch from d8c2e41 to e9b83b2 Compare May 10, 2023 21:29
@aoudiamoncef aoudiamoncef requested a review from modship May 10, 2023 21:51
@aoudiamoncef aoudiamoncef force-pushed the hotfix/final-slot-exec branch from e9b83b2 to 29f0bf8 Compare May 11, 2023 08:14
@aoudiamoncef
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented May 11, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 8617d55 into main May 11, 2023
@AurelienFT AurelienFT deleted the hotfix/final-slot-exec branch May 29, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ben-PH Ben-PH Ben-PH left review comments

@AurelienFT AurelienFT AurelienFT approved these changes

@modship modship Awaiting requested review from modship

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aoudiamoncef @modship @Ben-PH @AurelienFT