Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite tester con #3938

Merged
merged 7 commits into from
May 12, 2023
Merged

Fix infinite tester con #3938

merged 7 commits into from
May 12, 2023

Conversation

modship
Copy link
Member

@modship modship commented May 12, 2023 •
edited by AurelienFT
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

close #3937

@modship modship force-pushed the fix_infinite_tester_con branch from f7498d9 to b00f214 Compare May 12, 2023 08:51
@modship modship requested a review from AurelienFT May 12, 2023 08:52
@AurelienFT AurelienFT marked this pull request as ready for review May 12, 2023 10:24
@AurelienFT
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented May 12, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

  • build

@bors bors bot merged commit 6aed46f into main May 12, 2023
@AurelienFT AurelienFT deleted the fix_infinite_tester_con branch May 29, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid launching infinite tester connections
2 participants
@modship @AurelienFT