Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/peek loop #3948

Merged
merged 33 commits into from
May 15, 2023
Merged

Hotfix/peek loop #3948

merged 33 commits into from
May 15, 2023

Conversation

Ben-PH
Copy link
Contributor

@Ben-PH Ben-PH commented May 15, 2023 •
edited
Loading

Adapted from #3881

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Ben-PH and others added 30 commits April 28, 2023 12:56
@Ben-PH
Use dedicated deserializer for client-binder msg receive
3519398
@Ben-PH
Use helper method to decode data in known-len component of msg frm cl…
125c1f3 
…ient
@Ben-PH
In client-binder, use helper method instead of a dedicated deser-struct
e64dd15
@Ben-PH
Remove redundant TODO
7ae357b
@Ben-PH
Bootstrap/constify (#3883)
ca3a5c6 
* Derive the byte-count in a message length in const-context

* Use compile-time knowledge
@Ben-PH
Use timeout-updating read-loop. Use peek_exact_timeout helper
03321ee
@Ben-PH
Send message to client in single write_all
ad38081
@Ben-PH
Document new helper methods
d7c46a0
@Ben-PH
Make the servers send_timeout more readable
89b5c60
@Ben-PH
Revert the use of peek to a read-exact
4aff56a
@Ben-PH
Use traits to implement read_exact without code duplication
041662c
@Ben-PH
Remove unused peek implementation
4c7a5b5
@Ben-PH
Comment the new methods
01fa710
@Ben-PH
Clear clippy lints
d006490
@Ben-PH
Client sends message in a single write
472ed63
@Ben-PH
Implement and use the traits for the server binder
9c6055c
@Ben-PH
Module rearrangement
5676e9b
@Ben-PH
Merge remote-tracking branch 'origin/testnet_22' into bootstrap/use-r…
17eafbd 
…ead-loop
@Ben-PH
cargo fmt --all
93c43a3
@Ben-PH
Self review
c92b93d
@Ben-PH
Merge remote-tracking branch 'origin/testnet_22' into bootstrap/messa…
35a5c2d 
…ge-deser
@Ben-PH
Merge remote-tracking branch 'origin/bootstrap/use-read-loop' into bo…
497e76e 
…otstrap/message-deser
@AurelienFT
Create new branch testnet 23
4775dc6
@AurelienFT
Update version in constants
8493469
@Ben-PH
Delete file that somehow missed the deletion-memo
9e5abd5
@Ben-PH
Merge branch 'testnet_23' into bootstrap/message-deser
9f8bd55
@Ben-PH
Clear clippy lints
54aa34c
@Ben-PH
Bootstrap/use read loop (#3885)
1e65518
@Ben-PH
Merge branch 'testnet_23' into bootstrap/message-deser
9b867ed
@Ben-PH
rename peek and friends to reflect the reversion of peek usage
0102c2e
@Ben-PH Ben-PH requested a review from AurelienFT May 15, 2023 09:05
@Ben-PH Ben-PH marked this pull request as ready for review May 15, 2023 09:06
@AurelienFT AurelienFT mentioned this pull request May 15, 2023
Closed
@AurelienFT
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented May 15, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 570ce46 into main May 15, 2023
@AurelienFT AurelienFT deleted the hotfix/peek-loop branch May 29, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ben-PH @AurelienFT