Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use try_send instead of send in protocol #3983

Merged
merged 2 commits into from
May 25, 2023
Merged

use try_send instead of send in protocol #3983

merged 2 commits into from
May 25, 2023

Conversation

modship
Copy link
Member

@modship modship commented May 25, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

close : #3967

@modship modship linked an issue May 25, 2023 that may be closed by this pull request
Use try send instead of send in most of the channels intractions in protocol #3967
Closed
@modship modship requested a review from AurelienFT May 25, 2023 11:31
AurelienFT
AurelienFT suggested changes May 25, 2023
View reviewed changes
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already assigned the issue to myself because we made a diagram with damir about what should be send and what should be try_send.
It's not too big problem because your PR is a good start and so I will adjust from the diagram this afternoon.

@AurelienFT AurelienFT merged commit ad1b10f into testnet_23 May 25, 2023
@AurelienFT AurelienFT mentioned this pull request May 25, 2023
Closed
@AurelienFT AurelienFT deleted the protocol/use_try_send_channel branch May 29, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use try send instead of send in most of the channels intractions in protocol
2 participants
@modship @AurelienFT