Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use saturating_add/sub when updating mip store stats + update version… #4008

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Use saturating_add/sub when updating mip store stats + update version… #4008

merged 3 commits into from
Jun 1, 2023

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented May 31, 2023

…ing documentation

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds requested review from Leo-Besancon and Eitu33 May 31, 2023 13:04
Leo-Besancon
Leo-Besancon approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc cleaning :)

@sydhds sydhds mentioned this pull request Jun 1, 2023
Open
18 tasks
Eitu33
Eitu33 reviewed Jun 1, 2023
View reviewed changes
massa-node/src/main.rs Outdated Show resolved Hide resolved
massa-versioning/src/lib.rs Outdated Show resolved Hide resolved
massa-versioning/src/lib.rs Outdated Show resolved Hide resolved
massa-versioning/src/lib.rs Show resolved Hide resolved
@sydhds sydhds force-pushed the feature/versioning_stats_math_fixes branch from a87a984 to f15d2a7 Compare June 1, 2023 09:50
@sydhds sydhds requested a review from Eitu33 June 1, 2023 09:55
@sydhds sydhds force-pushed the feature/versioning_stats_math_fixes branch from f15d2a7 to 46a07ca Compare June 1, 2023 12:09
@sydhds sydhds merged commit c627cb7 into testnet_23 Jun 1, 2023
@sydhds sydhds deleted the feature/versioning_stats_math_fixes branch June 1, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eitu33 Eitu33 Eitu33 approved these changes

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sydhds @Leo-Besancon @Eitu33