Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use keypair version to generate secret key in massa client #4011

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Use keypair version to generate secret key in massa client #4011

merged 2 commits into from
Jun 1, 2023

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Jun 1, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds mentioned this pull request Jun 1, 2023
Open
18 tasks
@sydhds sydhds requested a review from Leo-Besancon June 1, 2023 09:54
aoudiamoncef
aoudiamoncef reviewed Jun 1, 2023
View reviewed changes
massa-proto/proto/massa/api/v1/versioning.proto Outdated
@@ -46,3 +46,10 @@ enum ComponentStateId {
COMPONENT_STATE_ID_ACTIVE = 5;
COMPONENT_STATE_ID_FAILED = 6;
}

// Same as MipComponent enum in versioning package
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In proto files, always copy/paste the doc on Rust struct. This is will be added to autogenerated documentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@sydhds sydhds requested a review from aoudiamoncef June 1, 2023 12:28
aoudiamoncef
aoudiamoncef approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@aoudiamoncef aoudiamoncef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍🏻

aoudiamoncef
aoudiamoncef approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@aoudiamoncef aoudiamoncef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍🏻

@sydhds sydhds merged commit 2bc9873 into testnet_23 Jun 1, 2023
@sydhds sydhds deleted the feature/versioning/massa_client_use_factory branch June 1, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

@aoudiamoncef aoudiamoncef aoudiamoncef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sydhds @aoudiamoncef @Leo-Besancon