Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MassaDbLsmtree and RawMassaDB fields pub #4054

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

Leo-Besancon
Copy link
Collaborator

@Leo-Besancon Leo-Besancon commented Jun 7, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

In short, this PR is needed in order to build a Wrapped DB in the following PR: massalabs/massa-ledger-editor#1.

Additional info:
We have to build this wrapper because RocksDB refuses to open an existing DB if we don't put every Column Family of that DB.
As we removed LEDGER_CF, we can't open testnet22 ledger with the current massa-db struct.

@Leo-Besancon Leo-Besancon marked this pull request as ready for review June 7, 2023 17:43
@Leo-Besancon Leo-Besancon requested a review from litchipi June 8, 2023 06:15
@litchipi litchipi merged commit d73e995 into testnet_24 Jun 8, 2023
@litchipi
Copy link
Contributor

litchipi commented Jun 8, 2023

Arg sorry ! I didn't meant to merge it 😭

@Leo-Besancon Leo-Besancon deleted the make_massadblsmtree_pub branch June 8, 2023 06:43
@Leo-Besancon
Copy link
Collaborator Author

Arg sorry ! I didn't meant to merge it 😭

No worries, as long as you did not have any changes to suggest ;)

@litchipi
Copy link
Contributor

litchipi commented Jun 8, 2023

No no it was perfect !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants