Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ci #4066

Merged
merged 3 commits into from
Jun 12, 2023
Merged

fix ci #4066

merged 3 commits into from
Jun 12, 2023

Conversation

modship
Copy link
Member

@modship modship commented Jun 12, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@modship modship requested a review from AurelienFT June 12, 2023 12:59
@AurelienFT
Copy link
Contributor

bors merge

@AurelienFT AurelienFT mentioned this pull request Jun 12, 2023
Closed
@bors
Copy link
Contributor

bors bot commented Jun 12, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

  • build

@modship modship merged commit ec51acb into main Jun 12, 2023
@AurelienFT AurelienFT deleted the test_23_1 branch October 23, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@modship @AurelienFT