Fix address FromStr implementation #4076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ben-PH
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
playground link to show equivalence: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=fef86bfc770967843b72f1288a347cd0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Checked the implementations for other structs (basically looked at FromStr implementations and the code around it. Couldn't find any other instance of this problem.
Additionnaly, manually reviewing all the results from @Ben-PH 's regex (#4043 (comment)) did not reveal anything.