Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TN23 : improve metrics #4080

Merged
merged 2 commits into from
Jun 15, 2023
Merged

TN23 : improve metrics #4080

merged 2 commits into from
Jun 15, 2023

Conversation

modship
Copy link
Member

@modship modship commented Jun 13, 2023

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@modship modship requested review from damip and AurelienFT June 13, 2023 14:18
@bors bors bot merged commit 214a16e into main Jun 15, 2023
@AurelienFT AurelienFT deleted the add_metrics_TN_23 branch October 23, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants