Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include xor versioning #4090

Merged
merged 27 commits into from
Jun 15, 2023
Merged

Include xor versioning #4090

merged 27 commits into from
Jun 15, 2023

Conversation

Leo-Besancon
Copy link
Collaborator

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

modship and others added 20 commits June 13, 2023 16:13
@Leo-Besancon Leo-Besancon marked this pull request as ready for review June 15, 2023 09:54
@Leo-Besancon
Copy link
Collaborator Author

We need to test this on labnet and have the following behaviour:

  • Before the MipInfo relative to the FinalStateHashKind becomes active, nodes with and without this PR should stay sync
  • Afterwards, they are no longer sync
  • Afterwards, the nodes with the MipInfo can execute more operations while staying sync

@Leo-Besancon Leo-Besancon marked this pull request as draft June 15, 2023 10:09
@Leo-Besancon

This comment was marked as resolved.

Sign in to view
@Leo-Besancon Leo-Besancon marked this pull request as ready for review June 15, 2023 10:24
@damip
Copy link
Member

damip commented Jun 15, 2023

See #3852 (comment) to make it secure

@AurelienFT AurelienFT changed the base branch from debug_ops_lags to main June 15, 2023 16:11
@AurelienFT
Copy link
Contributor

bors merge

bors bot added a commit that referenced this pull request Jun 15, 2023
@bors @modship
@AurelienFT @sydhds @Leo-Besancon
Merge #4090
51aed98 
4090: Include xor versioning r=AurelienFT a=Leo-Besancon

* [ ] document all added functions
* [ ] try in sandbox /simulation/labnet
* [ ] unit tests on the added/changed features
  * [ ] make tests compile
  * [ ] make tests pass 
* [ ] add logs allowing easy debugging in case the changes caused problems
* [ ] if the API has changed, update the API specification

Co-authored-by: modship <yeskinokay@gmail.com>
Co-authored-by: AurelienFT <aurelien.foucault@epitech.eu>
Co-authored-by: sydhds <sydhds@gmail.com>
Co-authored-by: Leo-Besancon <lb@massa.net>
@bors
Copy link
Contributor

bors bot commented Jun 15, 2023

Build failed:

@AurelienFT
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 15, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@Leo-Besancon Leo-Besancon merged commit d3b3cf9 into main Jun 15, 2023
@AurelienFT AurelienFT deleted the include_xor_versioning branch October 23, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

@sydhds sydhds Awaiting requested review from sydhds

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Leo-Besancon @damip @AurelienFT @modship @sydhds