Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct consensus bug #4102

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Correct consensus bug #4102

merged 1 commit into from
Jun 19, 2023

Conversation

damip
Copy link
Member

@damip damip commented Jun 18, 2023 •
edited
Loading

Correcting an important bug fond through external auditing.

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@damip damip added the p1 label Jun 18, 2023
@damip damip linked an issue Jun 18, 2023 that may be closed by this pull request
Consensus bug #4103
Closed
@damip damip removed the p1 label Jun 18, 2023
@damip damip self-assigned this Jun 18, 2023
@damip damip merged commit 9c22f05 into testnet_24 Jun 19, 2023
@AurelienFT AurelienFT deleted the correct_consensus_bug branch October 23, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

Assignees

@damip damip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consensus bug
2 participants
@damip @AurelienFT