Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VERSIONING_CF bootstrap + cleanup #4118

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Fix VERSIONING_CF bootstrap + cleanup #4118

merged 2 commits into from
Jun 27, 2023

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Jun 19, 2023 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds
Copy link
Contributor Author

sydhds commented Jun 19, 2023

Fix #4105

Leo-Besancon
Leo-Besancon approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not easy to find these bugs, well done ;)

@sydhds sydhds force-pushed the feature/versioning_cf_bootstrap_fixes branch from d9431c9 to d0288a6 Compare June 22, 2023 06:54
@AurelienFT
Copy link
Contributor

@sydhds can you fix the tests please

@sydhds sydhds force-pushed the feature/versioning_cf_bootstrap_fixes branch from d0288a6 to 1ad18bf Compare June 26, 2023 15:38
AurelienFT
AurelienFT approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge :)

@sydhds sydhds merged commit 3c23ff1 into testnet_24 Jun 27, 2023
@sydhds sydhds deleted the feature/versioning_cf_bootstrap_fixes branch June 27, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sydhds @AurelienFT @Leo-Besancon