Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add double stake detection #4132

Merged
merged 7 commits into from
Jun 26, 2023
Merged

Add double stake detection #4132

merged 7 commits into from
Jun 26, 2023

Conversation

AurelienFT
Copy link
Contributor

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

Fix #4004

@AurelienFT AurelienFT requested a review from damip June 21, 2023 08:33
@AurelienFT AurelienFT mentioned this pull request Jun 21, 2023
Closed
7 tasks
AurelienFT and others added 2 commits June 22, 2023 22:51
@AurelienFT @damip
Update massa-execution-worker/src/execution.rs
dacb696 
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
@AurelienFT @damip
Update massa-factory-worker/src/block_factory.rs
1768945 
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
@AurelienFT AurelienFT requested a review from damip June 22, 2023 20:51
damip
damip approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@damip damip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AurelienFT AurelienFT merged commit 0a7f2c0 into testnet_24 Jun 26, 2023
@AurelienFT AurelienFT mentioned this pull request Jun 26, 2023
Closed
@AurelienFT AurelienFT deleted the add_protection_double_stake branch July 4, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damip damip damip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AurelienFT @damip