Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add final cursor to exec stats #4146

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Add final cursor to exec stats #4146

merged 1 commit into from
Jun 26, 2023

Conversation

aoudiamoncef
Copy link
Contributor

@aoudiamoncef aoudiamoncef commented Jun 23, 2023 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

resolves #4142

@aoudiamoncef aoudiamoncef force-pushed the feature/final-cursor branch from 1329c36 to 706f579 Compare June 26, 2023 08:40
@aoudiamoncef aoudiamoncef requested a review from AurelienFT June 26, 2023 08:59
@aoudiamoncef aoudiamoncef marked this pull request as ready for review June 26, 2023 08:59
@aoudiamoncef aoudiamoncef requested a review from modship June 26, 2023 08:59
AurelienFT
AurelienFT previously approved these changes Jun 26, 2023
View reviewed changes
@aoudiamoncef
Copy link
Contributor Author

aoudiamoncef commented Jun 26, 2023 •
edited
Loading

@AurelienFT the CI is failing... I should fixe the tests

@AurelienFT
Copy link
Contributor

@AurelienFT the CI is failing... I should fixe the tests

It's because you updated the version of massa-sc-runtime in the cargo lock. Revert this change and it should pass.

@aoudiamoncef
Copy link
Contributor Author

@AurelienFT the CI is failing... I should fixe the tests

It's because you updated the version of massa-sc-runtime in the cargo lock. Revert this change and it should pass.

I found it hihih, just rollback the cargo lock file

@aoudiamoncef aoudiamoncef force-pushed the feature/final-cursor branch from 706f579 to 2cc3572 Compare June 26, 2023 09:39
@aoudiamoncef
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 26, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@aoudiamoncef aoudiamoncef merged commit 3fd6fdd into main Jun 26, 2023
@AurelienFT AurelienFT deleted the feature/final-cursor branch October 23, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

@modship modship Awaiting requested review from modship

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

final cursor in get_status in client
2 participants
@aoudiamoncef @AurelienFT