-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor execution state reads #4152
Conversation
@damip I have a question about the bindings of the responses to the initial request filters: Currently, we are just using the order, with this way, we make things simple, but we close the door to parallelisation ? |
Actually we can already parallelize it with the order approach: just run all the requests (they are all read-locking) in parallel, see |
@aoudiamoncef @Leo-Besancon ready for review + merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally a good refactor! I didn't catch anything critical, but I think during our labnet tests we should check that the pos_state is consistant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in API side, LGTM
MACOS fails unrelated bootstrap bandwidth tests. I think we can merge |
Closes #4075