New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display of xof. #4155

Merged

AurelienFT merged 1 commit into testnet_24 from logs_hash_xof

Jun 26, 2023

Contributor

AurelienFT commented Jun 26, 2023

document all added functions
try in sandbox /simulation/labnet
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification

Fix : #4092 (comment)


          Fix display of xof.

02c4a07

AurelienFT requested a review from Leo-Besancon

June 26, 2023 14:04

Leo-Besancon approved these changes

View reviewed changes

Collaborator

Leo-Besancon left a comment

It may be confusing to default to this behaviour.. but on the other hand I don't see a basic case where it would be a problem either.

AurelienFT merged commit 36da2e9 into testnet_24

AurelienFT mentioned this pull request

Secure xor hashes #4092

Closed

Leo-Besancon linked an issue

that may be closed by this pull request

Network restart follow-up issue 2 #4000

Open

12 tasks

AurelienFT deleted the logs_hash_xof branch

July 4, 2023 16:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet