New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Ratio instead of Amount for versioning threshold #4177

Merged

sydhds merged 3 commits into testnet_24 from feature/versioning_threshold_use_ratio

Jul 3, 2023

Contributor

sydhds commented Jun 30, 2023

document all added functions
try in sandbox /simulation/labnet
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification

sydhds requested review from damip and Leo-Besancon

June 30, 2023 08:47

damip reviewed

View reviewed changes

massa-serialization/src/lib.rs Show resolved Hide resolved

Leo-Besancon reviewed

View reviewed changes

massa-versioning/src/versioning.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-versioning/src/versioning.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-versioning/src/versioning.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-versioning/src/versioning.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-models/src/config/constants.rs Show resolved Hide resolved

sydhds requested review from damip and Leo-Besancon

June 30, 2023 10:19

Leo-Besancon approved these changes

View reviewed changes

Collaborator

Leo-Besancon left a comment

Much better now :)

Member

damip commented Jul 3, 2023

@sydhds there are merge conflicts

sydhds added 3 commits

July 3, 2023 10:57


          Use Ratio instead of Amount for versioning threshold

29aaaac


          Use ratio instead of pourcentage

a29a598


          Fix versioning unit tests compilation

7a75202

sydhds force-pushed the feature/versioning_threshold_use_ratio branch from 9208c26 to 7a75202 Compare

July 3, 2023 09:02

sydhds merged commit 9a88c5a into testnet_24

sydhds deleted the feature/versioning_threshold_use_ratio branch

July 3, 2023 09:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet