Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize deferred credits fetch #4622

Merged
merged 8 commits into from
Jan 9, 2024
Merged

Optimize deferred credits fetch #4622

merged 8 commits into from
Jan 9, 2024

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Jan 9, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds requested review from Leo-Besancon and damip January 9, 2024 17:06
@sydhds sydhds requested a review from damip January 9, 2024 17:11
damip
damip reviewed Jan 9, 2024
View reviewed changes
massa-api/src/public.rs Outdated Show resolved Hide resolved
Leo-Besancon
Leo-Besancon approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Left a small comment above)

@damip damip self-requested a review January 9, 2024 18:44
damip
damip requested changes Jan 9, 2024
View reviewed changes
Copy link
Member

@damip damip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: GRPC API

@damip
Copy link
Member

damip commented Jan 9, 2024

Actually let's assume GRPC is OK for now. We'll respond accordingly if there is any issue. Also, given the fact that we will reduce the whole deferred credits file, it should not be an issue.

@damip damip self-requested a review January 9, 2024 19:00
@damip damip merged commit d1c6258 into fix_db_number_ordering Jan 9, 2024
@sydhds sydhds deleted the deferred_credits_fetch_optim branch January 10, 2024 07:54
@Leo-Besancon Leo-Besancon linked an issue Jan 10, 2024 that may be closed by this pull request
get_address endpoint performance on the mainnet JSON RPC API #4618
Closed
github-merge-queue bot pushed a commit that referenced this pull request Jan 10, 2024
@Leo-Besancon @sydhds @damip
Fix DB serialization order for Ord types (#4619)
4dbac57 
* Update cycle db serialization

* Revert to previous cycle handling in get_cycle_history_cycles

(assumes keys are sorted in DB)

* Update ser / deser for cycles and deferred credits slots

* Add comment for AsyncPool behaviour

* Added comments

* Fmt

* Update test comment for pos_cache_recompute

* Address review comment

* Updated deferred_credits test to verify the fix

* Use take_while instead of break

* Update VERSION

* Optimize deferred credits fetch (#4622)

* Optimize deferred credits fetch

* Fix get_addresses test compilation

* Remove test print statements

* Use config for deferred credits delta

* Move to Settings

* minor fixes

* minor fixes 2

* double comment

---------

Co-authored-by: sydhds <sydhds@gmail.com>
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>

* Add warning for get_deferred_credits_range function and document addr_filter

* Review comment

* Bumped deferred_credits_delta to 3 months by default

* Update initial ledger and README

* Update genesis files + commit_id

---------

Co-authored-by: Sydhds <sylvain.delhomme@gmail.com>
Co-authored-by: sydhds <sydhds@gmail.com>
Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

@damip damip Awaiting requested review from damip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_address endpoint performance on the mainnet JSON RPC API
3 participants
@sydhds @damip @Leo-Besancon