Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial code for execution info #4685

Merged
merged 10 commits into from
May 15, 2024
Merged

Initial code for execution info #4685

merged 10 commits into from
May 15, 2024

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented May 6, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@sydhds sydhds requested a review from AurelienFT May 6, 2024 10:08
massa-execution-exports/src/controller_traits.rs Outdated Show resolved Hide resolved
massa-execution-exports/src/lib.rs Outdated Show resolved Hide resolved
massa-execution-exports/src/types.rs Show resolved Hide resolved
massa-execution-worker/src/execution_info.rs Show resolved Hide resolved
@sydhds sydhds mentioned this pull request May 13, 2024
1 task
@sydhds sydhds force-pushed the feature/execute_info_1 branch from 13881e5 to d7371ad Compare May 13, 2024 14:42
@sydhds sydhds requested a review from AurelienFT May 14, 2024 13:35
@sydhds
Copy link
Contributor Author

sydhds commented May 15, 2024

ExecuteInfoForSlot has more fields than ExecutionOutput so it makes sense to have both structures as it is defined in this PR. Let me know if this is still an issue @AurelienFT ?

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 72.86822% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 71.78%. Comparing base (8b23f0a) to head (ef7b13a).
Report is 4 commits behind head on main.

Files Patch % Lines
massa-execution-worker/src/execution.rs 76.54% 19 Missing ⚠️
massa-execution-worker/src/context.rs 78.94% 8 Missing ⚠️
...ssa-execution-worker/src/speculative_roll_state.rs 0.00% 6 Missing ⚠️
massa-execution-exports/src/channels.rs 0.00% 1 Missing ⚠️
massa-execution-exports/src/types.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4685   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files         291      291           
  Lines       51642    51642           
=======================================
  Hits        37069    37069           
  Misses      14573    14573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AurelienFT AurelienFT added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 6f9acc3 May 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants